Added an accuracy field to bows. #4852
Conversation
… not change with inaccuracy. I ended rewriting most of the code I previously wrote, and testing was a nightmare, but I got it done. I learned a lot about the codebase and how to implement other features in the future.
Particle scaling (MCreator#4720)
|
Hey, just heads up that we are porting to 1.20.6 right now so there may be some delay in merging of PRs |
There was a problem hiding this comment.
Thank you for your contribution.
I have left some comments.
As we are currently in the porting phase, expect that you will also need to provide the 1.20.6 code in the future. We may also not be able to provide much mentoring during porting.
I would recommend considering helping with porting right now if you want to do more PRs at this time.
plugins/generator-1.20.4/neoforge-1.20.4/templates/projectile/projectile.java.ftl
Outdated
Show resolved
Hide resolved
plugins/generator-1.20.4/neoforge-1.20.4/templates/item/item.java.ftl
Outdated
Show resolved
Hide resolved
plugins/generator-1.20.1/forge-1.20.1/templates/item/item.java.ftl
Outdated
Show resolved
Hide resolved
|
Thank you for being kind to me as I learn how to contribute to open-source projects. |
No problem, you are more than welcome! ;) Just please in the future don't mark as resolved as this is task of reviewer to mark as resolved if/when they review and consider it done :)
Yes, and updating all the code. Check out #4823 and existing pull requests tagged with "[1.20.6]" in title to see how we do this ;) |
|
My bad, I thought I was supposed to mark as resolved as I fixed them. |
plugins/mcreator-localization/help/default/item/rangedAccuracy.md
Outdated
Show resolved
Hide resolved
plugins/generator-1.20.4/neoforge-1.20.4/templates/projectile/projectile.java.ftl
Show resolved
Hide resolved
plugins/mcreator-localization/help/default/item/rangedAccuracy.md
Outdated
Show resolved
Hide resolved
plugins/mcreator-localization/help/default/item/rangedAccuracy.md
Outdated
Show resolved
Hide resolved
| world.addFreshEntity(projectile); | ||
| world.playSound(null, entity.getX(), entity.getY(), entity.getZ(), ForgeRegistries.SOUND_EVENTS | ||
| .getValue(new ResourceLocation("entity.arrow.shoot")), SoundSource.PLAYERS, 1, 1f / (world.getRandom().nextFloat() * 0.5f + 1)); | ||
| </#if> | ||
|
|
There was a problem hiding this comment.
This is also unrelated. Applies to both MC versions. Please use https://github.com/MCreator/MCreator/pull/4852/files tab to find such changes.
Please fix all of them, not just the ones I mark
| @@ -1052,6 +1052,7 @@ Color.white, new Procedure("condition4"), | |||
| item.projectile = new ProjectileEntry(modElement.getWorkspace(), | |||
| getRandomDataListEntry(random, ElementUtil.loadArrowProjectiles(modElement.getWorkspace()))); | |||
| item.shootConstantly = emptyLists; | |||
| item.rangedAccuracy = 1; | |||
There was a problem hiding this comment.
Test value should differ from default value in UI
|
Since we merged another item/projectile related PR, you will need to merge master branch into your branch and fix some of the merge conflicts that happened during this process |
|
Little busy, I'll deal with merge conflicts as soon as I can |
|
When you have time, no rush :D |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Do not remove this label manually, it should be removed by the bot when new activity occurs. |
|
If you have ever time to continue working on this, feel free to re-open the PR |
Does what the title says. This adds an extra field onto ranged items, which lets you specify the accuracy of the projectiles shot out. I tested it to oblivion so I don't think it breaks anything.