Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.6] Ported Screens datalist #4849

Merged
merged 3 commits into from
May 24, 2024
Merged

Conversation

Spectrall368
Copy link
Collaborator

Reordered and Ported Screens Mapping

@KlemenDEV
Copy link
Contributor

What did you base the ordering on here, since there is no particular file for screens?

@Spectrall368
Copy link
Collaborator Author

Spectrall368 commented May 19, 2024

What did you base the ordering on here, since there is no particular file for screens?

I ordered them based on who came first (file)

@Spectrall368
Copy link
Collaborator Author

Example: net.minecraft.client.gui.components.PopupScreen comes before net.minecraft.client.gui.screens.achievement.StatsScreen

@Defeatomizer
Copy link
Collaborator

The order of 1.20.4 mappings was suggested by me on #4623 so that it is more/less sorted and at the same time minimally categorized.

@KlemenDEV
Copy link
Contributor

In this case it may make sense to keep the order of @Defeatomizer

@Spectrall368
Copy link
Collaborator Author

Ok :(

@KlemenDEV KlemenDEV marked this pull request as draft May 20, 2024 16:52
@KlemenDEV
Copy link
Contributor

It may help to explain the order idea @Defeatomizer

@Defeatomizer
Copy link
Collaborator

The first category is 3 "main" screens of the game:

  • Hard-coded default value of Ingame;
  • MainMenu and IngameMenu;

Next we have screens rendered above the one identified by "Ingame" value, in-game screens:

  • Block/entity/item interface screens, alphabetically sorted;

And then there are all the other screens found in MC:

  • All other screens (not related to Realms), alphabetically sorted.

Basically a lot of screens are used inside game worlds, and I thought splitting the data list by this almost boolean criterion only does not make the order complex enough to get lost in it.

@Spectrall368 Spectrall368 marked this pull request as ready for review May 21, 2024 13:04

#LEGACY
Realms32bitWarning: WarningScreen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a very specific one, I would say you can safely remove it (also from datalist and old mappings)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@KlemenDEV KlemenDEV marked this pull request as draft May 22, 2024 11:57
@Spectrall368 Spectrall368 marked this pull request as ready for review May 23, 2024 14:03
Copy link
Contributor

@KlemenDEV KlemenDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@KlemenDEV KlemenDEV merged commit 0c82a62 into MCreator:1.20.6 May 24, 2024
1 check passed
@Spectrall368 Spectrall368 deleted the map_screens branch May 25, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants