[1.20.6] Ported Particle datalist #4846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also does not handle file move correctly, similar to #4827 |
this is not GitHub's fault, you had already started the particle.yaml file, I just finished it |
|
Aha I see, makes sense. I will run local diff then |
KlemenDEV
reviewed
May 20, 2024
KlemenDEV
requested changes
May 22, 2024
There was a problem hiding this comment.
Could you remove LEGACY particles from all mappings and datalists since no supported version holds them anymore? I have also noticed our datalists contain ENTITY_EFFECT which is not simple particle type and thus should not be on the lists so this one should be removed together with other removals
Other parts look good :) Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported particle mapping