Minor improvement for mod elements list D&D logic #4842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At this point it looks like |
|
If they are redundant and don't contribute anything outside making code hard to read, you can remove them, but make sure to do extensive testing (to prevent bugs like the one we are investigating right now with dynamic procedure dependencies from appearing) |
|
Marking as draft to make it more clear there are planned changes. Mark as RFR once you do them, thanks! |
KlemenDEV
added
the
community review
Spectrall368
approved these changes
May 23, 2024
KlemenDEV
reviewed
May 23, 2024
src/main/java/net/mcreator/ui/component/JSelectableListMouseListenerWithDND.java
Outdated
Show resolved
Hide resolved
KlemenDEV
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With changes in this PR, when mouse is released, the listener sets the selection array to the list indices selected. This array is then checked when mouse dragging starts, and if it is non-null and the next click point is inside one of selected cells, the D&D action begins.