Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Place feature at" procedure blocks #4715

Merged

Conversation

AlsoSomeoneElse
Copy link
Collaborator

  • Added a datalist of configured features
  • Added a base type for mod elements that provide a configured feature (currently all feature ME + blocks and plants if generation is enabled)
  • Added "Try to place feature at" procedure block, with a variant that returns if the procedure was actually placed

@AlsoSomeoneElse AlsoSomeoneElse added the new feature New feature or request label Mar 19, 2024
@KlemenDEV
Copy link
Contributor

KlemenDEV commented Mar 21, 2024

I did some tests and seems most vanilla features don't want to place (global trigger "On bucket used"). I was testing some underground features on the surface and they don't place. Isn't it that placement is ignored and those should be placed correctly?

@KlemenDEV
Copy link
Contributor

KlemenDEV commented Mar 21, 2024

I have also tested placing custom mod element configured feature (NBT-based feature) and only one block is placed (updated, all blocks actually place as one can't go through them - ghost blocks) on the global trigger "when right-clicked on block". However, this is not the case with vanilla features (when they do place).

Are we sure this procedure is reliable enough to not cause bug reports due to its limited use?

@AlsoSomeoneElse
Copy link
Collaborator Author

I did some tests and seems most vanilla features don't want to place (global trigger "On bucket used"). I was testing some underground features on the surface and they don't place. Isn't it that placement is ignored and those should be placed correctly?

Some features have additional placement defined in the feature itself rather than the placement (for example desert wells can only generate on sand). This is also why the additional generation condition isn't disabled in #4713. Ideally the procedure block works the same as /place feature.

I have also tested placing custom mod element configured feature (NBT-based feature) and only one block is placed (updated, all blocks actually place as one can't go through them - ghost blocks) on the global trigger "when right-clicked on block". However, this is not the case with vanilla features (when they do place).

I can look into the NBT-based feature to see if it can be fixed, but some vanilla features also generate ghost blocks (block piles for example - MC-248248)

Are we sure this procedure is reliable enough to not cause bug reports due to its limited use?

We could add a warning message to the place feature procedures, like for the NBT procedures.

@KlemenDEV
Copy link
Contributor

Thank you for the detailed explanation!

I agree with a warning to avoid issues on the issue tracker

@KlemenDEV KlemenDEV added the community review Used by maintainers to mark issues that should get community reviews, tests, and feedback label Mar 22, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Do not remove this label manually, it should be removed by the bot when new activity occurs.

@github-actions github-actions bot added the stale Stale issue label Apr 8, 2024
@KlemenDEV KlemenDEV removed the stale Stale issue label Apr 8, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Do not remove this label manually, it should be removed by the bot when new activity occurs.

@github-actions github-actions bot added the stale Stale issue label Apr 24, 2024
@KlemenDEV KlemenDEV removed the stale Stale issue label Apr 24, 2024
Copy link
Contributor

github-actions bot commented May 9, 2024

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Do not remove this label manually, it should be removed by the bot when new activity occurs.

@github-actions github-actions bot added the stale Stale issue label May 9, 2024
@KlemenDEV KlemenDEV removed the stale Stale issue label May 9, 2024
@KlemenDEV KlemenDEV added this to the 2024.2 milestone May 11, 2024
@KlemenDEV KlemenDEV removed the community review Used by maintainers to mark issues that should get community reviews, tests, and feedback label May 25, 2024
@KlemenDEV KlemenDEV self-assigned this May 30, 2024
Copy link
Contributor

@KlemenDEV KlemenDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@KlemenDEV KlemenDEV merged commit 65bb483 into MCreator:master Jun 4, 2024
2 checks passed
@KlemenDEV
Copy link
Contributor

KlemenDEV commented Jun 4, 2024

A port of procedures and data list is now needed for 1.20.6 in the future

KlemenDEV added a commit that referenced this pull request Jun 4, 2024
@AlsoSomeoneElse AlsoSomeoneElse deleted the place_feature_procedure_block branch June 4, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants