-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "Place feature at" procedure blocks #4715
Added "Place feature at" procedure blocks #4715
Conversation
AlsoSomeoneElse
commented
Mar 19, 2024
- Added a datalist of configured features
- Added a base type for mod elements that provide a configured feature (currently all feature ME + blocks and plants if generation is enabled)
- Added "Try to place feature at" procedure block, with a variant that returns if the procedure was actually placed
…ace_feature_procedure_block
I did some tests and seems most vanilla features don't want to place (global trigger "On bucket used"). I was testing some underground features on the surface and they don't place. Isn't it that placement is ignored and those should be placed correctly? |
I have also tested placing custom mod element configured feature (NBT-based feature) and only one block is placed (updated, all blocks actually place as one can't go through them - ghost blocks) on the global trigger "when right-clicked on block". However, this is not the case with vanilla features (when they do place). Are we sure this procedure is reliable enough to not cause bug reports due to its limited use? |
Some features have additional placement defined in the feature itself rather than the placement (for example desert wells can only generate on sand). This is also why the additional generation condition isn't disabled in #4713. Ideally the procedure block works the same as
I can look into the NBT-based feature to see if it can be fixed, but some vanilla features also generate ghost blocks (block piles for example - MC-248248)
We could add a warning message to the place feature procedures, like for the NBT procedures. |
Thank you for the detailed explanation! I agree with a warning to avoid issues on the issue tracker |
…ace_feature_procedure_block
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Do not remove this label manually, it should be removed by the bot when new activity occurs. |
…ace_feature_procedure_block
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Do not remove this label manually, it should be removed by the bot when new activity occurs. |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Do not remove this label manually, it should be removed by the bot when new activity occurs. |
…ace_feature_procedure_block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
A port of procedures and data list is now needed for 1.20.6 in the future |