Multiple tabs support #4399
Open
Multiple tabs support #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defeatomizer
added
the
community review
Goldorion
reviewed
Nov 19, 2023
src/test/java/net/mcreator/integration/TestWorkspaceDataProvider.java
Outdated
Show resolved
Hide resolved
Defeatomizer
added
the
changes FV
plugins/mcreator-localization/help/default/common/creative_tabs.md
Outdated
Show resolved
Hide resolved
Spectrall368
approved these changes
Nov 20, 2023
KlemenDEV
reviewed
Nov 20, 2023
src/test/java/net/mcreator/integration/TestWorkspaceDataProvider.java
Outdated
Show resolved
Hide resolved
This reverts commit 9d058e0.
|
A question unrelated to this PR: shouldn't we add the operator tab mapping as it's available in both currently supported versions? |
|
Oops, thanks a lot, misclick. |
|
There are some merge conflicts due to recent FV change |
|
GitHub ignores pressing Commit merge button 🤷♂️ RIP |
|
What is wrong now? I don't see the error locally 🤷♂️ |
|
Code does not even build |
|
Not locally, that's why I'm asking. |
KlemenDEV
requested changes
May 14, 2024
|
Please do not just change FV number but also re-test |
KlemenDEV
added
the
on hold
|
On hold for #4818 |
KlemenDEV
removed
the
on hold
|
FV bump needed |
# Conflicts: # src/main/java/net/mcreator/ui/modgui/ArmorGUI.java # src/main/java/net/mcreator/ui/modgui/PlantGUI.java
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Do not remove this label manually, it should be removed by the bot when new activity occurs. |
Spectrall368
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creativeTab/igniterTabtocreativeTabs(in both storage classes and GUI);"No creative tab entry"because it means the same as an empty list specified usingTabListField;