Refacto menu + mod-vertical + scrollBox #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvalentin-lucca
force-pushed
the
refacto.menu
branch
from
3a83fc1
to
426ff04
Compare
vvalentin-lucca
force-pushed
the
refacto.menu
branch
from
3d3f58b
to
79bd4d3
Compare
vvalentin-lucca
changed the title
Comment on lines
62
to
64
| <span class="menu-list-item-action is-disabled"> | ||
| Menu 3 | ||
| </span> |
There was a problem hiding this comment.
Just out of curiosity: Why not only removing the href attribute? So that we don’t inherit some styles?
There was a problem hiding this comment.
I haven't even tried it, actually... due to ignorance.
There was a problem hiding this comment.
I'm afraid including anchor tags without the href attribute in the docs will be confusing for some users.
There was a problem hiding this comment.
This can be documented if required. Both work for me.
jeremie-lucca
approved these changes
May 31, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
aare now withouthref.mod-Sis now automatically applied to any embedded digital badges.mod-verticalhas been added..scrollBox) now displays a scrollbar and shadows when necessary.