Enable loss-parallel in example #19882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fabric
⚡ Required checks status: All passing 🟢Groups summary🟢 lightning_fabric: Azure GPU
These checks are required after the changes to Thank you for your contribution! 💜
|
for more information, see https://pre-commit.ci
Borda
approved these changes
May 20, 2024
carmocca
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables loss_parallel for loss computation and backward as suggested by @carmocca #19879 (comment). In Fabric the user has convenient control over that. In LightningModule, the user has to override the backward hook in addition to the modification in the training step hook.
📚 Documentation preview 📚: https://pytorch-lightning--19882.org.readthedocs.build/en/19882/
cc @Borda @carmocca @justusschock @awaelchli