Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode serial from bytes before concatenation in libadobe.py #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnboiles
Copy link

Without this, on Python 3.9.7 and Python 3.10.12, running python3 register_ADE_account.py would result in this stacktrace:

Traceback (most recent call last):
  File "/root/register_ADE_account.py", line 78, in <module>
    main()
  File "/root/register_ADE_account.py", line 50, in main
    success = createDeviceFile(True, VAR_VER)
  File "/root/libadobeAccount.py", line 64, in createDeviceFile
    fingerprint = makeFingerprint(serial)
  File "/root/libadobe.py", line 249, in makeFingerprint
    str_to_hash = serial + devkey_bytes.decode('latin-1')
TypeError: can't concat str to bytes

@Leseratte10
Copy link
Owner

Thanks for the PR. Though, I'm not quite sure why / if it is necessary. I've just spun up a Docker container with Python 3.10.12 and the script is running just fine as-is, without this change.

Did you test the latest release (0.0.16) or the most up-to-date version from Git (0.1.0-something)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants