Code cleanup #155
Open
Code cleanup #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits starts the process of standardization and cleanup towards a more lint-able and pep8 compiliant code.
The windows release
sylveon
requested changes
Aug 4, 2018
There was a problem hiding this comment.
See comment I left on commit.
Also for heaven's sake, please see #154, you just released a broken version! https://github.com/LazoCoder/Pokemon-Terminal/blob/master/pokemonterminal/platform/named_event/posix.py#L32
|
Pretty sure that won't work, because we're calling __str__ as if it was a static method. Maybe we should add a new method to the interface (something like |
|
This could use a rebase 😅 |
|
Lots of conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request starts the process of standardization and cleanup towards a more lint-able and pep8 compliant code.
I want to first to focus only on the obvious and the one git hates the most, spacing and lines, and the missing
@staticmethodannotations, but this is not purely for aesthetics, I really want to clean the house up of all the silly defaults we have laying around so we can add more rigid linting to our CI process.But I also want to keep the PR's focused in order for more focused discussion and consensus for each part.