Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from #ifdef WITH_EXPENSIVE_ASSERTIONS to expensiveAssert #260

Open
Mikolaj opened this issue Aug 4, 2021 · 0 comments
Open

Switch from #ifdef WITH_EXPENSIVE_ASSERTIONS to expensiveAssert #260

Mikolaj opened this issue Aug 4, 2021 · 0 comments

Comments

@Mikolaj
Copy link
Member

Mikolaj commented Aug 4, 2021

Define expensiveAssert (as in Cabal codebase) in Game.LambdaHack.Core.Prelude using #ifdef WITH_EXPENSIVE_ASSERTIONS and use everywhere. This avoids polluting a lot of the code with ifdefs.

Make sure it works in Allure of the Stars as well (e.g., when running Allure CI) and that it would work when used in Allure codebase (currently not used). It's fine if that requires the with_expensive_assertions flag for both LambdaHack and Allure in cabal.project for Allure.

See https://github.com/haskell/cabal/blob/769e4ede066108cf722ac4828884788429c2d310/cabal-install-solver/src-assertion/Distribution/Client/Utils/Assertion.hs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant