Redesign the UI #69
Merged
Redesign the UI #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobbyESP
requested changes
Jun 5, 2024
| @@ -103,7 +102,7 @@ | |||
| <string name="set_sd_path">Establece aquí la ruta de tu tarjeta SD. Esto es necesario para Android 10 y versiones anteriores.</string> | |||
| <string name="no_sd_card_path_set">¡No se ha establecido la ruta de la tarjeta SD!</string> | |||
| <string name="sd_card_path_set_successfully">¡Ruta de la tarjeta SD establecida con éxito!</string> | |||
| <string name="clear_sd_card_path">Borrar ruta de la tarjeta SD</string> | |||
There was a problem hiding this comment.
I would recommend to change the resource name/id since now it's more indentificable as "clear". Also the other modified strings
| org.gradle.jvmargs=-Xmx2048M -Dkotlin.daemon.jvm.options\="-Xmx2048M" -Dfile.encoding\=UTF-8 |
There was a problem hiding this comment.
This may be a better option to leave it non defined
| sharedContentState = rememberSharedContentState(key = "cover$id"), | ||
| animatedVisibilityScope = animatedVisibilityScope, | ||
| clipInOverlayDuringTransition = sharedTransitionScope.OverlayClip( | ||
| RoundedCornerShape( |
There was a problem hiding this comment.
For shapes it's recommended to use dp unit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.