Allocation Check #459
Open
Allocation Check #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a prerequisite test for any builds where the resource manager is set (i.e., not NONE). - `make check` now sets `--stop-on-failure`, essentially preventing tests from running outside of a job allocation - allocation checker script is examples/check_allocation.sh and can be extended in the future
|
@gonsie review this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #320
This changes the behavior of
make checkto add the option--stop-on-failure. It also adds a 'check allocation' test/script before any of the parallel tests are run. The idea is that this script will check that users have a proper allocation before running the tests and prevent the very slow running of multiple 'srun' commands outside of an allocation. It only prevents users from running if they usemake checkand will not stop all the parallel tests from running if the users usemake test... but at least it will print out an error message the users can stare at while their srun is queueing.Right now only the fact that the script is in allocation is checked (that is, that a job id environment variable is set).
Things to add: