Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add webpack configuration to allow browser builds #230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeswr
Copy link
Member

@jeswr jeswr commented Feb 9, 2022

No description provided.

@jeswr
Copy link
Member Author

jeswr commented Feb 9, 2022

Once merged (or as part of this PR) - it would be good to have scripts that send the build to an equivalent repo to https://github.com/rdfjs/comunica-browser with CDN builds of LDflex.

@rubensworks - assuming this is a valid idea to you have permissions to create the appropriate repo in the rdfjs org and give me write access? From there I assuming it is just a matter of copy/pasting the CDN workflow scripts from https://github.com/comunica/comunica

@@ -69,5 +74,8 @@
},
"publishConfig": {
"access": "public"
},
"browser": {
"./index.js": "./index.js"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a no-op, so shouldn't be needed.

@rubensworks
Copy link
Collaborator

There's also this directory with (Solid-specific) LDflex webpack configs: https://github.com/LDflex/Query-Solid/tree/master/webpack

Given that these exist, does it still make sense to have separate browser builds for LDflex (without query engine)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants