switch from walk to EMERGENCY(faster walk) as last resort mode #3488 #3512
Conversation
| Some(Right(TransitModes.TRANSIT)), | ||
| TransportMode.other | ||
| ) | ||
|
|
There was a problem hiding this comment.
Do we really need this EMERGENCY_TRANSIT mode? Why we cannot use just EMERGENCY even if there is a TRANSIT leg in it?
| @@ -115,7 +118,10 @@ object EmbodiedBeamTrip { | |||
| theMode = leg.beamLeg.mode | |||
| } else if (theMode == WALK && leg.beamLeg.mode == BIKE) { | |||
| theMode = leg.beamLeg.mode | |||
| } else if (theMode == WALK && leg.beamLeg.mode == EMERGENCY) { | |||
| theMode = EMERGENCY | |||
There was a problem hiding this comment.
- Because we introduce a new possible return value for
EmbodiedBeamTrip#tripClassifierthen we need to carefully check all the pattern matching on this field to validate that there wouldn't be aMatchError. - Also because EMERGENCY trip is actually a WALK trip. Then we need to check all the places where
tripClassiferis compared with WALK (i.e. ) and add these EMERGENCY there.
| @@ -126,6 +132,8 @@ object EmbodiedBeamTrip { | |||
| DRIVE_TRANSIT | |||
| } else if (theMode == TRANSIT && hasUsedBike) { | |||
| BIKE_TRANSIT | |||
| } else if (theMode == TRANSIT && hasUsedEMERGENCY) { | |||
| EMERGENCY_TRANSIT | |||
There was a problem hiding this comment.
I think that it's safier not to change these method at all. But in this case we wouldn't have EMERGENCY in PathTraversalEvent.
src/main/scala/beam/agentsim/agents/modalbehaviors/ChoosesMode.scala
Outdated
Show resolved
Hide resolved
|
The actual emergency trip is a teleportation trip (as this task suggests) or a Walk trip? |
Xuan-1998
changed the title
I was intending to change it to be a teleportation initially, but now I guess a faster Walk trip will be easier to validate |
| @@ -261,7 +242,22 @@ object PersonAgent { | |||
| bodyVehicleId: Id[BeamVehicle], | |||
| bodyVehicleTypeId: Id[BeamVehicleType] | |||
| ): EmbodiedBeamTrip = { | |||
| if (trip.tripClassifier != WALK && trip.tripClassifier != WALK_TRANSIT) { | |||
| if (trip.tripClassifier != EMERGENCY && trip.tripClassifier != EMERGENCY) { | |||
There was a problem hiding this comment.
This seems like a copy/paste error or something to that extent - as the condition is the same
|
WIP |
This change is