Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update libcurl to 8.5.0 [n/a] #22

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

filfreire
Copy link
Member

@filfreire filfreire commented Dec 7, 2023

This PR aims to solve a dependency versioning problem we currently have.

It's not assigned to an issue on Linear, but we have spotted this problem while working on INS-3359

  • insomnia on develop uses our - 2.3.6-21 node-libcurl release which does not use the 8.4.0 libcurl, uses the 7.79.1 🛑
  • the only release we had supporting libcurl with 8.4.0 is our node-libcurl of 2.3.6-20 🛑

In this PR - we bump Libcurl dependency to 8.5.0. This node-libcurl build is available to test/debug on https://github.com/Kong/node-libcurl/releases/tag/v2.4.1-2

cc @jackkav if this is all green, it should be safe to merge to develop, and no need to re-tag/re-release -as it's available on 2.4.1-2

@filfreire filfreire requested review from jackkav and a team December 7, 2023 12:55
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@2d0a3fa). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #22   +/-   ##
==========================================
  Coverage           ?   93.51%           
==========================================
  Files              ?       44           
  Lines              ?      940           
  Branches           ?       97           
==========================================
  Hits               ?      879           
  Misses             ?       41           
  Partials           ?       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants