New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clustering/rpc): more strict parameter checking when generating a RPC error #12951

Open

chronolaw wants to merge 5 commits into master from style/clustering_rpc_small_clean

+19 −2

Contributor

chronolaw commented Apr 28, 2024 •

edited

Summary

minor code style improvement.

Checklist

The Pull Request has tests
A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]


style(clustering/rpc): minor code style improvment

482a266

chronolaw added the skip-changelog label

pull-request-size bot added the size/XS label

github-actions bot assigned chronolaw

github-actions bot added core/clustering cherry-pick kong-ee labels

chronolaw requested a review from ADD-SP

April 28, 2024 02:04

ADD-SP reviewed

View reviewed changes

kong/clustering/rpc/json_rpc_v2.lua Outdated Show resolved Hide resolved

ADD-SP reviewed

View reviewed changes

kong/clustering/rpc/json_rpc_v2.lua Outdated Show resolved Hide resolved


assert tostring msg

0526a2f

chronolaw force-pushed the style/clustering_rpc_small_clean branch from e6cbce1 to 0526a2f Compare

April 28, 2024 02:52

ADD-SP reviewed

View reviewed changes

kong/clustering/rpc/json_rpc_v2.lua Outdated Show resolved Hide resolved

ADD-SP reviewed

View reviewed changes

kong/clustering/rpc/json_rpc_v2.lua Outdated Show resolved Hide resolved


apply suggestion

9e8b739

pull-request-size bot added size/S and removed size/XS labels

ADD-SP reviewed

View reviewed changes

kong/clustering/rpc/json_rpc_v2.lua Outdated Show resolved Hide resolved


Update kong/clustering/rpc/json_rpc_v2.lua

dc6429d

ADD-SP previously approved these changes

View reviewed changes

bungle changed the title ~~style(clustering/rpc): minor code style improvment~~ style(clustering/rpc): minor code style improvement

ADD-SP changed the title ~~style(clustering/rpc): minor code style improvement~~ fix(clustering/rpc): more strict parameter checking when generating a RPC error

ADD-SP dismissed their stale review

April 30, 2024 03:11

With the past several changes, this PR became a fix, not style, needs more works.

ADD-SP removed the skip-changelog label

Contributor

ADD-SP commented Apr 30, 2024

Removed label skip-changelog as I would consider this PR is a fix.


changelog

607212f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment