Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/environment edit modal save #7330

Closed

Conversation

oahmed-OS
Copy link
Contributor

@oahmed-OS oahmed-OS commented Apr 28, 2024

Background

For environment override modifications, the current behavior did not persist these changes consistently. This is not consistent with the expected behavior of persisting changes as the user closes and re-opens the modal after submitting some change.

This was caused by two issues:

  • onBlur was not firing consistently on modal close
  • Updated values was not loaded in debug route collection and was not re-rendered on change

Changes

  • Capture save on hide rather then on blur
  • Update collection in debug route when change detected using new collection state
  • add smoke test

Closes #5612

@CLAassistant
Copy link

CLAassistant commented Apr 28, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@filfreire filfreire force-pushed the fix/environment-edit-modal-save branch from e917120 to b03d873 Compare April 29, 2024 13:57
@oahmed-OS
Copy link
Contributor Author

failing smoke tests, found more acceptable solution - will open a separate PR.

@oahmed-OS oahmed-OS closed this May 3, 2024
@oahmed-OS oahmed-OS deleted the fix/environment-edit-modal-save branch May 3, 2024 23:26
@oahmed-OS oahmed-OS mentioned this pull request May 4, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment variables at folder level not saving state
2 participants