Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch Plane Sweep Algorithm from GUI #176

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

ALouis38
Copy link
Contributor

A simple GUI for launching the plane sweep algorithm (depthmaps generation) of PlaneSweepLib directly from the Map-TK's GUI.
How to use:

  • Load a project containing cameras and landmarks into mapgui.
  • Go to Compute -> Depthmaps... -> Plane Sweep Lib
  • Indicate the path to your version of PlaneSweepLib/build/bin/cudaPlanesweepMAPTk
  • Compute

You can input any value for the different PSL parameters but the ones by default should work well.

@@ -0,0 +1,351 @@
/*ckwg +29
* Copyright 2015 by Kitware, Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright 2016

@mleotta
Copy link
Member

mleotta commented Jun 24, 2016

I haven't reviewed the code, but I tested it and it works for me.

This is a helpful tool to run things as they are now. We can probably land this branch, but ultimately I'd like to see the Plane sweep command line tool go away. Here is my high-level vision about where I'd like to see this go in the future. An we will be helping with this at KUS starting soon.

  1. We write an abstract algorithm interface in KWIVER for depth map estimation that takes in a set of images with corresponding camera models, a depth range, etc. and produces a depth image, confidence (uniqueness) image, and best cost image.
  2. We modify the PlaneSweepLib clone that @bastienjacquet has to build a KWIVER plugin that implements this new API using the PlaneSweepLib code. This plugin will be GPL and continue to live outside of KWIVER.
  3. We port the cudaPlanesweepMAPTk tool from PlaneSweepLib to MAP-Tk and revise it to use MAP-Tk and KWIVER data structures for images, cameras, etc. This will call the new abstract algorithm for depth map estimation.
  4. We modify this branch to directly call the depth map API from the GUI instead of an external executable.
  5. We add an alternative implementation for depth estimation using Super3D that can now be called from either the command line tool or the GUI.

We'll get started with task 1 soon.

Your output dialog reminded me of something I've mentioned to @mwoehlke-kitware in the past. I'd really like to see a dialog window like this that displays the log messages sent to the Vital logger so we can see the console output as the GUI is running algorithms. This would be very helpful, especially on platforms like Windows. I'm not suggesting that should be part of this branch, but maybe we can reuse this output dialog in the future.

@ALouis38 ALouis38 mentioned this pull request Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants