Add missing header references in test Cmake #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test builds currently rely on the build loader dependency on the openxr headers for those headers to be pulled. Make the dependency explicit for tests so that when the loader is not built, the headers are still pulled.
|
|
|
How are you building anything else at all without the loader being built? It still needs the loader. |
|
I use a pre-built loader here pfontain@2e7def6 |
|
An issue (number 2179) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2179 ), to facilitate working group processes. This GitHub pull request will continue to be the main site of discussion. |
|
I think that, now that Meta has moved to the standard loader, this is no longer needed? |
|
Probably. Thank you for the heads up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test builds currently rely on the build loader dependency on the openxr headers for those headers to be pulled. This merge request makes the dependency explicit for tests, so that when the building the loader is off, the headers are still pulled.