Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable read environment variable on Android #431

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RenfengLiu
Copy link

This fixs: #430

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2023

CLA assistant check
All committers have signed the CLA.

@rpavlik
Copy link
Contributor

rpavlik commented Oct 16, 2023

The underlying issue is that there's no way to set those environment variables from outside the app, so they don't actually serve the purpose intended. (though, there may not be implicit layer support on android at all yet? or maybe just from manifests?)

A port of the behavior is more likely to be using getprop with some prefix before the environment variable name, I suspect.

What's your use case?

@RenfengLiu
Copy link
Author

RenfengLiu commented Oct 16, 2023

There are two ways applications can set the environment variable:

@RenfengLiu
Copy link
Author

The underlying issue is that there's no way to set those environment variables from outside the app, so they don't actually serve the purpose intended. (though, there may not be implicit layer support on android at all yet? or maybe just from manifests?)

A port of the behavior is more likely to be using getprop with some prefix before the environment variable name, I suspect.

What's your use case?

The use case is hoping that there's will same mechanism used in other platforms that can load the explicit layer or implicit layer when requested. The implict layers without the enable_environment works, but this loads the layer for all applications, which is not the desired behavior.

Using getprop would be another option, but this might require the Android system reserve that prop.

@rpavlik-bot rpavlik-bot added the synced to gitlab Synchronized to OpenXR internal GitLab label Dec 11, 2023
@rpavlik-bot
Copy link
Collaborator

An issue (number 2160) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2160 ), to facilitate working group processes.

This GitHub pull request will continue to be the main site of discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
synced to gitlab Synchronized to OpenXR internal GitLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants