Fixes #19741 - Undefined method split for nil on tests

[dLobatog]

Due to a bug on minitest that is being currently fixed, our tests are
broken when they run as the "test_develop_pr_katello" job in Jenkins.

The fix is published as minitest/minitest#696
however there is no version of minitest with it yet. A possible
workaround is to prevent these assertions like this PR does.

[dLobatog]

There is a job http://ci.theforeman.org/job/test_develop_pr_katello/2894/ running the affected Jenkins job with this PR, it should hopefully confirm that the workaround is valid.

[dLobatog]

Apparently the job needs a PR in Foreman to work too, not sure how to verify this.

[sean797]

Thanks for fixing this @dLobatog ! 👍

EDIT: I reproduce this locally and this seem to fix it... I have no idea about how to get our Jenkins to verify

[dLobatog]

@sean797 How do you reproduce it locally?

[sean797]

Sorry @dLobatog when I said locally I meant with another Jenkins.. At the moment I have access to lots of massively overspec'ed and underutilized Jenkins workers so I setup jobs from https://github.com/theforeman/foreman-infra while I was testing another PR. My laptop sounds like an airplane taking off if I run the whole tests suit locally ✈️

This also for example fixes: (which is nice)

DEPRECATED: Use assert_nil if expecting nil from /home/vagrant/katello/test/models/sync_plan_test.rb:35. This will fail in Minitest 6.

[lzap]

Finally, thanks!

[lzap]

Quick merge anyone? This is bugging me for weeks now! Thanks. @ehelms @jlsherrill @parthaa

[jlsherrill]

ACK thanks @lzap !

[dLobatog]

\o/