SSH #359

lievenhey · 2022-01-18T12:16:07Z

These patches allow hotspot to run perf record on remote devices via ssh. The recording data is streamed directly to hotspot without storing it on the device.

fixes #12

GitMensch · 2022-03-01T06:35:49Z

Thank you for this nice addition, it seems that README.md may need an update (or is this actually a draft implementation so "too early for that")?

README.md

src/perfrecordssh.cpp

src/ssh.cpp

src/perfrecordssh.cpp

src/ssh.cpp

lievenhey · 2022-07-29T09:12:07Z

weird, somehow the ui on the mainwindow got changed, but I didn't touch that file.

GitMensch · 2022-09-16T13:47:39Z

@milianw I'm wondering where this has gone, the requested changes seem to have been done.

src/perfrecordssh.cpp

src/ssh.h

milianw · 2022-09-30T19:40:18Z

src/perfrecordssh.h

+
+class QFile;
+
+class PerfRecordSSH : public PerfRecord


please add some basic documentation on how this is implemented. basically just something that says we overload a bunch of API to disable features and then use an external ssh process to communicate with another machine to remote control the perf session there

milianw · 2022-09-30T19:40:44Z

src/ssh.h

+class QStringList;
+class QProcessEnvironment;
+
+QStringList assembleSSHArguments(const QString& deviceName, const QStringList& command);


please add basic api documentation to all of these

src/ssh.h

jeff-dagenais · 2022-10-05T17:19:34Z

related to #12

GitMensch · 2022-10-06T06:04:15Z

related to #12

Actually this "fixes #12" - maybe someone can edit the first post or better directly link it.

GitMensch · 2022-11-14T13:47:59Z

Solving the conflicts would be nice; the reason I'm asking for it is that this would trigger CI, which now creates an AppImage which then can be used to test the feature before it is integrated.

GitMensch · 2022-11-30T09:32:07Z

I've tested that with the generated appimage and when doing "test connection and save" I always just get an empty error message:

with stderr having

QProcess: Destroyed while process ("/usr/bin/ssh") is still running.

How to debug this issue? (note: /usr/bin/ssh -K ruser@rmach works like a charm)

Side note: the configuration dialog is named "Paths and Architecture Settings" which is getting even more wrong after applying this, I've created #436 to tackle that.

lievenhey · 2022-11-30T15:10:07Z

@GitMensch ~~It should now work~~ connecting does work, recording not (I messed up the order of arguments and ended up calling ssh host@user)

GitMensch · 2022-11-30T15:36:05Z

Rechecked with hotspot-v1.3.0-374-g97c6a8e-x86_64.AppImage - still the same result (empty error + that message in stderr).
Can I suggest to add "command failed: $sshCommandHere" as start of the error message?

complete rewrite

milianw

only had time for the first patch for now

src/multiconfigwidget.cpp

src/multiconfigwidget.h

src/recordpage.cpp

milianw

I think we also need some basic test coverage for this, maybe for starters a manual test binary that we can invoke manually to run some tests

then integrate that into the docker images somehow?

src/models/eventmodelproxy.cpp

src/multiconfigwidget.cpp

src/multiconfigwidget.h

src/settingsdialog.cpp

src/remotedevice.cpp

This change makes it more usable by making the usage easier. Simply add the edit widget as a child using addChild and be done. Now you only need to call saveCurrentConfig and be done. Restoring and saving are handled by the widget.

you can edit you devices, copy your ssh key and select you ssh binary on this page device are stored directly in a KConfigGroup, the deviceList property of Settings is only there to pass the devices around to other widgets

Changes to existing logic: RecordHost now saved the client app args RecordHost no longer differentiate between local and remote when setting the output file name, since the file is always saved on the host New class RemoteDevice, this class handles communication between the host and the remote device. It does this by using a multiplexed ssh connection. This is faster since we only need to do authentification once and can then reuse the existing connection.

There is some logic left from the time before RecordHost. This patch removes these fragments

this patch finally runs perf via ssh on a remote device perf is run with -o - to stream the recording to the host in this case stderr contains the output of the program run

using coroutines allows use async io without having to deal with multithreading

lievenhey force-pushed the ssh branch from bd4771c to e76012b Compare January 18, 2022 12:27

lievenhey force-pushed the ssh branch 2 times, most recently from db9e69e to 4708a99 Compare January 27, 2022 16:20

lievenhey force-pushed the ssh branch 2 times, most recently from ad512da to a52b519 Compare February 3, 2022 12:06

lievenhey force-pushed the ssh branch from a52b519 to ec5615d Compare April 26, 2022 11:32

milianw requested changes Apr 26, 2022

View reviewed changes

lievenhey force-pushed the ssh branch 3 times, most recently from b42ef40 to 80b6728 Compare July 29, 2022 08:50

milianw previously requested changes Sep 30, 2022

View reviewed changes

lievenhey force-pushed the ssh branch 5 times, most recently from 04a8c5c to 7b84340 Compare November 16, 2022 14:45

lievenhey force-pushed the ssh branch 2 times, most recently from 6ded45e to 46759d0 Compare November 30, 2022 15:08

lievenhey force-pushed the ssh branch 3 times, most recently from a2e4a03 to 97c6a8e Compare November 30, 2022 15:15

GitMensch mentioned this pull request Jul 4, 2023

remove query stuff from record page #454

Merged

lievenhey force-pushed the ssh branch from 5b5eadc to 9ba5451 Compare September 14, 2023 14:05

lievenhey force-pushed the ssh branch 3 times, most recently from 5744272 to 9dada8c Compare September 18, 2023 13:31

lievenhey marked this pull request as ready for review September 18, 2023 13:32

lievenhey force-pushed the ssh branch 5 times, most recently from c0ad183 to 673f977 Compare September 19, 2023 14:22

milianw requested changes Sep 21, 2023

View reviewed changes

lievenhey force-pushed the ssh branch 3 times, most recently from df88ae9 to 4a48461 Compare September 21, 2023 11:59

milianw requested changes Sep 28, 2023

View reviewed changes

lievenhey force-pushed the ssh branch 4 times, most recently from b05d3b6 to d3e1b24 Compare October 5, 2023 10:41

lievenhey added 5 commits October 31, 2023 12:03

rewrite MultiConfigWidget

5c7083f

This change makes it more usable by making the usage easier. Simply add the edit widget as a child using addChild and be done. Now you only need to call saveCurrentConfig and be done. Restoring and saving are handled by the widget.

add ssh settings page

f4029d1

you can edit you devices, copy your ssh key and select you ssh binary on this page device are stored directly in a KConfigGroup, the deviceList property of Settings is only there to pass the devices around to other widgets

integrate RecordHost in PerfRecord

5f913da

There is some logic left from the time before RecordHost. This patch removes these fragments

replace QPointer with std::uniqur_ptr in PerfRecord

2689f1b

lievenhey force-pushed the ssh branch from d3e1b24 to 6c4fb96 Compare October 31, 2023 11:05

lievenhey added 2 commits October 31, 2023 12:58

add recording via ssh

2b56d33

this patch finally runs perf via ssh on a remote device perf is run with -o - to stream the recording to the host in this case stderr contains the output of the program run

use qcoro for async ssh control

0d5ce75

using coroutines allows use async io without having to deal with multithreading

lievenhey force-pushed the ssh branch from 6c4fb96 to 0d5ce75 Compare October 31, 2023 11:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SSH #359

SSH #359

lievenhey commented Jan 18, 2022 •

edited

GitMensch commented Mar 1, 2022

lievenhey commented Jul 29, 2022

GitMensch commented Sep 16, 2022

milianw Sep 30, 2022

milianw Sep 30, 2022

jeff-dagenais commented Oct 5, 2022

GitMensch commented Oct 6, 2022

GitMensch commented Nov 14, 2022

GitMensch commented Nov 30, 2022

lievenhey commented Nov 30, 2022 •

edited

GitMensch commented Nov 30, 2022

milianw left a comment

milianw left a comment

SSH #359

Are you sure you want to change the base?

SSH #359

Conversation

lievenhey commented Jan 18, 2022 • edited

GitMensch commented Mar 1, 2022

lievenhey commented Jul 29, 2022

GitMensch commented Sep 16, 2022

milianw Sep 30, 2022

Choose a reason for hiding this comment

milianw Sep 30, 2022

Choose a reason for hiding this comment

jeff-dagenais commented Oct 5, 2022

GitMensch commented Oct 6, 2022

GitMensch commented Nov 14, 2022

GitMensch commented Nov 30, 2022

lievenhey commented Nov 30, 2022 • edited

GitMensch commented Nov 30, 2022

milianw left a comment

Choose a reason for hiding this comment

milianw left a comment

Choose a reason for hiding this comment

lievenhey commented Jan 18, 2022 •

edited

lievenhey commented Nov 30, 2022 •

edited