This repository has been archived by the owner on Sep 24, 2023. It is now read-only.
Port to QtKeychain #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we optionally use KWallet to store passwords and fall back to storing it in a settings file. Instead use QtKeychain to store the password in the platforms respective native API (which happens to be KWallet on Plasma). This should improve the cross-platformness of the app and matches the general direction KDE is taking wrt KWallet. It also considerably simplifies the implifies the implementation since we no longer need to handle the optionalness of KWallet
nicolasfella
requested review from
krf,
dfaure-kdab,
frankosterfeld and
winterz
|
|
||
| job->start(); | ||
|
|
||
| Settings::setPassword(QString()); // ensure no plain-text password from before in the config file |
There was a problem hiding this comment.
should this be kept in the case the write job fails? I'd say security over keeping the password at all costs though.
| if (job->error() == QKeychain::AccessDeniedByUser) { | ||
| mDeniedByUser = true; | ||
| } | ||
| } else { |
There was a problem hiding this comment.
should there be a mDeniedByUser = false; here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we optionally use KWallet to store passwords and fall back to
storing it in a settings file.
Instead use QtKeychain to store the password in the platforms respective
native API (which happens to be KWallet on Plasma).
This should improve the cross-platformness of the app and matches the
general direction KDE is taking wrt KWallet.
It also considerably simplifies the implifies the implementation since
we no longer need to handle the optionalness of KWallet