Tabulator expansion #104
Draft
Tabulator expansion #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #104 +/- ##
===========================================
- Coverage 82.38% 81.94% -0.44%
===========================================
Files 131 131
Lines 24303 24433 +130
===========================================
Hits 20022 20022
- Misses 4281 4411 +130 |
janssenhenning
force-pushed
the
tabulator-improvement
branch
from
dc33613
to
0e78e0d
Compare
…nto abstract class This way the superclass provides huge benefit as is shown by the example of a tabulator for NamedTuple (Even though this is not as impressive with the presence of the _asdict method of Namedtuple)
get_keypath is not a good name for extracting the actual value for a given keypath
for more information, see https://pre-commit.ci
janssenhenning
force-pushed
the
tabulator-improvement
branch
from
3ccf158
to
1c02cbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to consolidate the
Tabulatorclass in masci-tools/aiida-jutools. @Irratzo I hope you don't mind. I just noticed that the base class was essentially empty, which wastes a lot of potential.Most of the non-aiida specific code is moved into the abstract base class in masci-tools. Now the design requires implementing two functions
autolist: as before for a default set of paths to includeget_keypath: specifies how to extract a given path from an item to be tabulated (See examples at the bottom oftabulator.py)TODO:
NodeTabulator