Bump hardhat to 2.20

[kronosapiens]

Main

• Update to Hardhat 2.20 and cancun hardfork
• Remove calls to selfdestruct and update uninstall behavior for extensions
• Make better use of ColonyExtension.sol base class and remove boilerplate from extension contracts
• Make ColonyExtension.resolver public to facilitate testing of new uninstall behavior

Misc

• Miscellaneous improvements to coverage
• Split up reputation-test-non-gnosis Circle job to reduce total build times
• Make arguments to getMetatransactionNonce consistent among affected contracts

[area]

Make arguments to getMetatransactionNonce consistent among contracts

If this is the goal, then I believe you have missed:

• ColonyNetworkAuction
• IBasicMetaTransaction
• CoinMachine
• FundingQueue
• TokenSupplier
• Whitelist
• VotingReputationStorage
• VotingReputationMisaligned
• TokenLocking

Did you not touch incrementMetatransactionNonce because it's internal, or some other reason?

Fun to see a refactor that reduces duplication to the extent the coverage thresholds fail so more tests have to be written, that's good to see 😄

[area]

We should test that this is done (for all places where we do it, not just here). A good rule of thumb is that if you can remove a line of code and the tests still pass, you need to write more tests.

[kronosapiens]

I suppose. I would argue that we never tested the ether-returning function for selfdestruct, and so shouldn't need to test this now. But I can add an ether transfer check.

[area]

You're right, but we did test that it self-destructed (and then trusted that the opcode did the rest of what it was meant to do). We could not include this functionality, but I think that's a much worse outcome.

[area]

I am sure I don't need to remind you of my distaste for changing code in order to accommodate the tests! This isn't necessary, as we can just instantiate a contract as an EtherRouter like we do in other tests:

colonyNetwork/test/contracts-network/colony-expenditure.js

Lines 337 to 338 in 5fdb870

	const colonyNetworkAsEtherRouter = await EtherRouter.at(colonyNetwork.address);
	const latestResolver = await colonyNetworkAsEtherRouter.resolver();

[kronosapiens]

I tried that earlier and it did not work, for the reason that extensions instantiated directly (like CoinMachine.new) don't in fact inherit from EtherRouter. Alternatives would be to add a getResolver view function in ColonyExtension.sol or to access the storage slot directly, which wouldn't be my preference.

[kronosapiens]

Thinking about this more, I'm not sure if there's much benefit to including uninstall as part of the extension interface in general. We can still support uninstallExtension at the network-level, but the implementation should be changed to:

1. Remove all permissions from the extension in the colony
2. Delete the extension from the installations mapping

I say this because we already have a deprecate function which does all of the restricting that we would add to an uninstall function, which makes me think that an uninstall which locks all functions would be mostly redundant.

If anything, the uninstall function on the extension should perform checks to see if we are ready to uninstall the extension via the network. I'm thinking of streaming payments here, where uninstall would simply error if there were unclaimed funds.