Fix is_running_in_databricks function
#264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weichen Xu <[email protected]>
harupy
reviewed
May 20, 2024
nlu/utils/environment/env_utils.py
Outdated
Comment on lines
90
to
92
| if "IS_IN_DATABRICKS_MODEL_SERVING_ENV" in os.environ: | ||
| # Serving container installs apache/spark, not databricks runtime. | ||
| return False |
harupy
reviewed
May 20, 2024
nlu/utils/environment/env_utils.py
Outdated
| # Serving container installs apache/spark, not databricks runtime. | ||
| return False | ||
|
|
||
| if "DATABRICKS_RUNTIME_VERSION" in os.environ: |
There was a problem hiding this comment.
Suggested change
| if "DATABRICKS_RUNTIME_VERSION" in os.environ: | |
| return "DATABRICKS_RUNTIME_VERSION" in os.environ: |
can we just return this?
There was a problem hiding this comment.
@harupy will this variable be present for Databricks Clusters and absent in Databricks Endpoints?
Signed-off-by: Weichen Xu <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
is_running_in_databricksfunction