fix: Crash in aliased OpBoolean #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obabichevjb
reviewed
May 27, 2024
joc-a
force-pushed
the
joc/fix-crash-in-alias
branch
2 times, most recently
from
65b05b6
to
95a8db9
Compare
Syntax errors were being thrown for Oracle and SQL Server for this SQL statement: SELECT FOO.C1, FOO.C1 < FOO.C2 c1ltc2 FROM FOO ORDER BY FOO.C1 ASC Oracle: java.sql.SQLSyntaxErrorException: ORA-00923: FROM keyword not found where expected SQL Server: com.microsoft.sqlserver.jdbc.SQLServerException: Incorrect syntax near '<'.
joc-a
force-pushed
the
joc/fix-crash-in-alias
branch
from
95a8db9
to
36cbe97
Compare
obabichevjb
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix was made here initially but I had to add more changes, hence this PR.