Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to describe repeat step changes in more details #4067

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

porunov
Copy link
Member

@porunov porunov commented Oct 18, 2023

Fixes #3799


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

@porunov porunov added this to the Release v1.0.0 milestone Oct 18, 2023
@janusgraph-bot janusgraph-bot added the cla: external Externally-managed CLA label Oct 18, 2023
@@ -267,6 +267,8 @@ With `closest_repeat_parent` mode vertices for batch registration will be receiv
`repeat` step as well as the end of the closest `repeat` step (for the next iteration). Any other parent `repeat` steps
will be ignored.

See detailed `repeat` step batch processing explanation [here](https://medium.com/@porunov/janusgraph-1-0-0-batch-queries-multi-query-14abc8f66d93#b09f).
Copy link
Member

@li-boxuan li-boxuan Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's possible to create a JanusGraph official medium account, and copy your article there? And of course, you can link to the original post in the JanusGraph post. The idea is the links on official doc should be as permanent as possible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Will do that

@porunov porunov modified the milestones: Release v1.0.0, Unscheduled Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: external Externally-managed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the changelog and / or create a blog post about recent repeat step multi-query improvements
3 participants