Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle interruption for BerkeleyJE backend #3990

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

mad
Copy link
Contributor

@mad mad commented Sep 15, 2023

Fixes #2120


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

@janusgraph-bot janusgraph-bot added the cla: external Externally-managed CLA label Sep 15, 2023
@mad mad force-pushed the handle-bdb-interruption branch 2 times, most recently from de6260c to 8e25fe9 Compare September 18, 2023 08:02
Copy link
Member

@porunov porunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that the added test BerkeleyInterruptionTest passes (when enabled).
The refactoring changes looks good to me, but I didn't dive into the logic itself because I'm not using BerkeleyJE.
LGTM. Thank you @mad !

@li-boxuan li-boxuan added this to the Release v1.0.0 milestone Oct 6, 2023
@li-boxuan li-boxuan merged commit cdea0d7 into JanusGraph:master Oct 6, 2023
103 of 104 checks passed
@janusgraph-automations
Copy link

💚 All backports created successfully

Status Branch Result
v0.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@janusgraph-automations
Copy link

💚 All backports created successfully

Status Branch Result
v0.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@porunov
Copy link
Member

porunov commented Oct 6, 2023

@mad @li-boxuan apparently TP tests for BerkeleyJE were not executed in this PR, but they are failing now.
The problem is that simply adding [tp-tests] to the commit message and not to the PR name itself isn't enough to trigger TP tests in the PR anymore. We should probably fix it in GitHub actions, but I noticed that for a PR to trigger TP tests not only the commit message should include [tp-tests], but also a PR name itself should include [tp-tests].

@li-boxuan after merging this PR (commit cdea0d7 ) the master branch is now failing due to failed BerkeleyJE TP tests. We should either revert that commit or fix the bugs.

@li-boxuan
Copy link
Member

Revert PR: #4037

@li-boxuan
Copy link
Member

@mad I reverted this PR due to its failure for tp-tests. It would be great if you could reopen the PR after fixing it, thank you!

@tien
Copy link
Contributor

tien commented Apr 24, 2024

Would be great to have this fix available soon. Got a fright having the server crashed today 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.6 cla: external Externally-managed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JanusGraph image stop responding after query timeout
6 participants