Rewrite the Molang Autocomplete system to improve plugin extensibility. #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c991aae.
A rewrite of the Molang Autocomplete system to improve plugin extensibility.
✅ Deploy Preview for blockbench-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
IanSSenne
suggested changes
Apr 29, 2024
Also added an `id` field to the addQueryGetter function, and changedquery_getters property to a Map instead of a Set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a major rewrite of the Molang Autocomplete system in an attempt to allow plugins to modify it without overwriting it.
There are extensive comments throughout the code, and partial JSdoc typing.
I'm opening this PR now to allow Jannis and others to take a peek at it, and make suggestions.
If/when this PR is merged, I'll update the TS types to reflect these changes.