New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] optionally load only configured indexers. #9224
base: master
Are you sure you want to change the base?
[Feature] optionally load only configured indexers. #9224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will need to update in index.html the changed= datestamp in order to force the browser cache to refresh custom.js
<script type="text/javascript" src="../custom.js?changed=20200410"></script>
its the 698 line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, anomaly.
I have 334 indexers loaded normally.
with your PR active, I only get 331.
apparently, the following were not loaded?
AniRena, Channelx, RockBox
Are you loading only lowercase filenames?
the names of the files in the Indexers folder are based on the id: in the *.cs and *.yml definitions.
@garfield69 Can I assume indexer ids are case insensitive ? Can i assume the indexer id is the same as the yml file name ? or should i open the yml file and use the id inside it to make sure ? Can i assume the config files are save with the indexer id which may be camel case ? All yml definition files i saw except one (DasUnerwartete.yml) are lowercase. |
example: anirena.yml and id:aniRena and config file aniRena.json. similar for Channelx, RockBox Seems to be the reason for them not loading |
…ers with case sensitive discrepancies between indexer id and indexer definition file name
Optional indexer loading: force the browser cache to refresh custom.js Feature: optionally load only configured indexers - fix loading indexers with case sensitive discrepancies between indexer id and indexer definition file name
…' into feature_optional_indexer_loading
Squashed the commits as per the contribution instructions. Never did that before. Hope i didn't break anything. |
I believe the id is case sensitive (eg aniRena is not the same as anirena or ANIRENA)
no. the yml filename is not necessarily the same as the id. Usually they are lower case, but there are exceptions, such as Bittorrentfiles.yml and DasUnerwartete.yml previously created when there were no naming standards in place.
that would certainly be the safest and more reliable method
yes, the *.json files are created using the case sensitive id |
Current fix still assumes indexer id is same as file name except for case. Will fix to open yml and look at id later. |
… to id in definition file and not according to definition file name.
Fixed to load only configured indexers according to index id in the definition file and not using the indexer definition file name. As an aside, I think indexers ids should be UUID4 and only the display names should be used to actually represent the indexer to the user. This may complicates human (read:developer) accessibility to things, but can reduce the amount of workaround code (such as the need to rename indexers) |
Potential implementation for feature described in #7851.
Configuration setting to load all or only configured indexers.
Requires restart on config change