core: validate yaml definitions (go templates) #8597
Conversation
| @@ -95,14 +95,14 @@ search: | |||
| - name: re_replace # S01E01 to Сезон 1 Серии 1 | |||
| args: ["(?i)\\bS0*(\\d+)E0*(\\d+)\\b", "езон $1 ерии $2"] | |||
| inputs: | |||
| $raw: "{{range .Categories}}c{{.}}=1&{{end}}" | |||
| $raw: "{{ range .Categories }}c{{ . }}=1&{{ end }}" | |||
There was a problem hiding this comment.
the current Cardigann code will not accept any variation, returning (with slightly different keys)
Jackett.Common.IndexerException: Exception (0daykiev): The given key '. ' was not present in the dictionary.
---> System.Collections.Generic.KeyNotFoundException: The given key '. ' was not present in the dictionary.
at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
at Jackett.Common.Indexers.CardigannIndexer.applyGoTemplateText(String template, Dictionary`2 variables, TemplateTextModifier modifier) in d:\a\1\s\src\Jackett.Common\Indexers\CardigannIndexer.cs:line 441
at Jackett.Common.Indexers.CardigannIndexer.PerformQuery(TorznabQuery query) in d:\a\1\s\src\Jackett.Common\Indexers\CardigannIndexer.cs:line 1302
at Jackett.Common.Indexers.BaseIndexer.ResultsForQuery(TorznabQuery query) in d:\a\1\s\src\Jackett.Common\Indexers\BaseIndexer.cs:line 323
--- End of inner exception stack trace ---
at Jackett.Common.Indexers.BaseIndexer.ResultsForQuery(TorznabQuery query) in d:\a\1\s\src\Jackett.Common\Indexers\BaseIndexer.cs:line 343
at Jackett.Common.Indexers.BaseWebIndexer.ResultsForQuery(TorznabQuery query) in d:\a\1\s\src\Jackett.Common\Indexers\BaseIndexer.cs:line 799
at Jackett.Server.Controllers.ResultsController.Results(ApiSearch requestt) in d:\a\1\s\src\Jackett.Server\Controllers\ResultsController.cs:line 224
for any of the following
$raw: "{{ range .Categories }}c{{ . }}=1&{{ end }}"
$raw: "{{ range .Categories }}c{{. }}=1&{{ end }}"
$raw: "{{ range .Categories }}c{{ .}}=1&{{ end }}"
$raw: "{{ range .Categories }}c{{ . }}=1&{{end}}"
$raw: "{{ range .Categories }}c{{ .}}=1&{{end}}"
$raw: "{{ range .Categories }}c{{. }}=1&{{end}}"
$raw: "{{ range .Categories }}c{{.}}=1&{{ end }}"
$raw: "{{ range .Categories }}c{{.}}=1&{{end }}"
the late variation returned The given key '.}}=1&{{end' was not present in the dictionary.
only
`$raw: "{{ range .Categories }}c{{.}}=1&{{end}}"`
is accepted.
There was a problem hiding this comment.
Do you prefer the current implementation c{{.}}=1&{{end}} or with spaces c{{ . }}=1&{{ end }}?
I don't care, you are in charge or this part. I can make the changes in Cardigann if required.
There was a problem hiding this comment.
It seems to me that the current implementation of the range .Categories is out of step with what Cardigann does with the other templates, so yes, if you can amend Cardigann to handle spaces when processing the range then that is a worth doing. Thanks.
|
Close given 507f2f2? |
I don't think so. The range statement has a hardcoded dependence on |
DISCLAIMER!!! This is not tested and not reviewed. Maybe this PR is not necessary at all.
Take your time to review line by line and test the indexers if necessary. I can split this PR is smaller ones or rebase if it's required.
Don't block the other issues, let this for when you don't have other things to do. :)