cardigann: fix search paths #14493
Draft
cardigann: fix search paths #14493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ilike2burnthing take a look at the new commit :) |
|
Appreciate it, but I think the latest commits are more of a workaround, as we're then not using |
mynameisbogdan
force-pushed
the
cardigann-search-paths
branch
from
8ffea01
to
87a3fcb
Compare
mynameisbogdan
force-pushed
the
cardigann-search-paths
branch
from
87a3fcb
to
5ebe1de
Compare
|
Unfortunately this has the same drawbacks as before. You don't need to spend your time and energy on this, it's attempting to fix the tiniest of non-issues - saving us amending an additional line in a few definitions if their categories are ever updated. |
|
Haha, I'm more annoyed because I'm certain this should be the correct behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.