Allow constructor calls with generics #458
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain contexts. Also substitute generics in function calls, which includes constructors. Only issue now is that we must mark generics when checking class bodies. This means that we should check whether they exist in the context, but instead whether they are mentioned as a generic in the class name. The two new tests hint as this, but within this PR the generate stage should also preserve the generics of classes in the output.
JSAbrahams
added
enhancement: check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issues
Summary
Only issue now is that we must mark generics when
checking class bodies.
This means that we should check whether they exist in the context, but instead whether they are
mentioned as a generic in the class name.
The two new tests hint as this, but within this PR the generate stage should also preserve the
generics of classes in the output.
Added Tests