Update wrong task name in "Tasks Added" in README #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakingrufus
reviewed
Feb 16, 2023
| @@ -471,7 +471,7 @@ Then for each `SourceSet` plugin adds following tasks: | |||
| - `ktlint[source set name]SourceSetCheck` - generates reports and prints issues into Gradle console based on lint check found errors. | |||
| This task execution depends on `loadKtlintReporters` and `runKtlintCheckOver[source set name]SourceSet` tasks execution outputs | |||
| - `runKtlintFormatOver[source set name]SourceSet` - tries to format according to the code style every Kotlin file in given `SourceSet` | |||
| - `ktlint[source set name]SourceSetCheck` - generates reports and prints issues into Gradle console based on found non-formattable errors. | |||
| - `ktlint[source set name]SourceSetFormat` - generates reports and prints issues into Gradle console based on found non-formattable errors. | |||
There was a problem hiding this comment.
good catch! I think the description should be updated as well to indicate that the source files will be formatted.
In `Tasks Added` list, task `ktlint[source set name]SourceSetFormat` was wrongly named as `ktlint[source set name]SourceSetCheck`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the README, Tasks Added list includes the task
ktlint[source set name]SourceSetChecktwice.The second listing of the task should actually be named
ktlint[source set name]SourceSetFormat.