Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite: Minor refactors and documentation #104

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Rewrite: Minor refactors and documentation #104

wants to merge 2 commits into from

Conversation

JJTech0130
Copy link
Owner

@JJTech0130 JJTech0130 commented May 23, 2024 •
edited

  • Moved FilteredStream to filters.py
  • Renamed reconnect to _reconnect to reflect its non-public nature
  • Added docstrings to many functions

@JJTech0130
Copy link
Owner Author

Before this PR is merged, I want to remove the KNOWN_TOPICS_LOOKUP, and instead directly lookup topics inside lifecycle.py based on current filters only. Maybe keep something for debugging, used for __repr__ only?

@JJTech0130 JJTech0130 added this to the 2.1.0 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JJTech0130