Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved issue #6 navbar added and improper alignment of the sections resolved #66

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

singhrimiumesh
Copy link

Changes Made

Added a navbar to the page for better navigation.
Adjusted alignment of the sections to ensure proper layout.

Details

Added HTML structure for the navbar and included necessary CSS styles.
The sticky navbar enhances user experience by providing easy access to navigation options.
Ensured that the navbar spans the full width of the page for improved aesthetics.
Corrected alignment issues with the sections to maintain a consistent layout across different screen sizes.

Screenshots

Before : no navbar and improper alignment
Screenshot 2024-05-11 123709

Now : Added Sticky Navbar and resolved the alignment issue
Screenshot 2024-05-11 123728

Copy link

vercel bot commented May 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
community-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 5:55am

Copy link

netlify bot commented May 11, 2024

Deploy Preview for opensourcevillage ready!

Name Link
🔨 Latest commit 2639dcd
🔍 Latest deploy log https://app.netlify.com/sites/opensourcevillage/deploys/664ae5d31a6a0f0008b00621
😎 Deploy Preview https://deploy-preview-66--opensourcevillage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@singhrimiumesh
Copy link
Author

@Its-Aman-Yadav , and you please review and add the label as gssoc24 and level1

@Its-Aman-Yadav
Copy link
Owner

Navbar is not looking so good make it more clear and visible @singhrimiumesh

@Its-Aman-Yadav Its-Aman-Yadav self-requested a review May 12, 2024 06:52
css/style.css Outdated
@@ -71,6 +77,65 @@ strong {
font-weight: 700;
}


nav {
background-color: rgba(255, 255, 255, 0.2);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it more clear

@bhaavvya
Copy link

Heyy @singhrimiumesh can you please resolve the issues.

@Its-Aman-Yadav
Copy link
Owner

Hey @singhrimiumesh are you still working on it?

@Its-Aman-Yadav
Copy link
Owner

image
It is looking like this, please make changes

Copy link
Owner

@Its-Aman-Yadav Its-Aman-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the old navbar and place yours

Copy link
Owner

@Its-Aman-Yadav Its-Aman-Yadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes are not aligned with the site, please make meaningful changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants