Fix bug with compromised tests #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Invictum hi. How are you? Any updates? =) |
|
@Invictum any updates? |
|
@Invictum Hey, how are you? |
|
@Invictum Are you still here? |
|
Hi @Invictum. How are you? |
|
Hi @Invictum and @grey-rain could you merge my PR. This would help us to remove our internal version and start updating version of integration. Thanks. |
grey-rain
reviewed
Sep 16, 2023
| @@ -18,7 +18,7 @@ | |||
| * Common test recorder suitable for most cases | |||
| */ | |||
| public class Regular extends TestRecorder { | |||
| static final int RETRIES_COUNT = ReportIntegrationConfig.get().retriesCount(); | |||
| final int RETRIES_COUNT = ReportIntegrationConfig.get().retriesCount(); | |||
There was a problem hiding this comment.
as it is not a constant anymore, please rename it to camelCase. Could you please provide any insights about why this change was required BTW? :)
I do not mind changing it, just want to understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that compromised tests could be executed by JUnit twice and duplicated in the Report Portal. This fix should help with this.
Before:
After: