-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two authentication method in one App #128
base: main
Are you sure you want to change the base?
Conversation
Hi Jonas, I am getting this error in PR
Fixing docs/docs/multi-tenant/azure_setup.mdx Not sure how to fix it. Could you please advise. Thanks |
Thank you 🚀 EDIT: Edit: ohhh, I see, the pipeline fails. It is because we use pre-commit. If you have pre-commit locally, you can write You can read about pre-commit in the CONTRIBUTING.md file 😊 The files have probably been fixed, but you need to
You'll see that the change made by pre-commit isn't staged. As a side note: I'm at the airport, going to PyCon and a little vacation, so it might take a while before I get to review this PR 😊 |
Thanks alot, no rush at all, Enjoy your vacation and no work please:)
I will do it through git command on Monday (Friday night in New Zealand).
Today I did it through the github website.
Have a safe trip:)
Cheers
Mohsen
…On Fri, 14 Apr 2023, 18:51 Rhuan Barreto, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/docs/multi-tenant/azure_setup.mdx
<#128 (comment)>
:
> @@ -3,14 +3,20 @@ title: Azure configuration
sidebar_position: 1
---
-We'll need to create two application registrations for Azure AD authentication to cover both direct API
-use and usage from the OpenAPI (swagger) documentation.
+We'll need to create two authentication methods for Azure AD authentication to cover both direct API use and usage from the OpenAPI (swagger) documentation. We can achieve this goal in two ways:
+<ol>
+<li> Create two different Azure Apps </li>
+<li> Create one Azure App with two (an App can have mutile authentication method) authentication methods </li>
⬇️ Suggested change
-<li> Create one Azure App with two (an App can have mutile authentication method) authentication methods </li>
+<li> Create one Azure App with two (an App can have multiple authentication methods) authentication methods </li>
—
Reply to this email directly, view it on GitHub
<#128 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2EOQMOGKFAJNIFXCWAHAQ3XBDXYJANCNFSM6AAAAAAW5ZDEYU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
ohhh, thanks for spotting these Co-authored-by: Rhuan Barreto <[email protected]>
Hey @mohsspark829 😊 I have not forgot about this, but have not found the time. I'll try to get back to you soon. |
Hey Jonas, great to hear from you:) Sure, thanks, if you need any
additional materials, please let me know. Have a great weekend.
Cheers
Mohsen
…On Sat, 20 May 2023, 04:00 Jonas Krüger Svensson, ***@***.***> wrote:
Hey @mohsspark829 <https://github.com/mohsspark829> 😊 I have not forgot
about this, but have not found the time. I'll try to get back to you soon.
—
Reply to this email directly, view it on GitHub
<#128 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2EOQMIKCDQWW3QB5O7ARPLXG6KKXANCNFSM6AAAAAAW5ZDEYU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks:)