BUG: VTKPolyDataMeshIO support for reading VTK 5.1 format #4669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Bug
dzenanz
approved these changes
May 16, 2024
This format is not documented per: - Kitware/VTK@7f76b9e - https://gitlab.kitware.com/vtk/vtk/-/issues/17989 - https://discourse.vtk.org/t/legacy-polydata-file-compatibility/5354/11 so best guess implementation. Continue to write with the older form, which is supported by more software. Closes InsightSoftwareConsortium#4478
|
@dzenanz thanks for the review. Other reviews are welcome, but I will merge this by the end of the day to have the bug addressed for the 5.4.0 release. |
seanm
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This format is not documented per:
so best guess implementation.
Continue to write with the older form, which is supported by more software.
Closes #4478