-
-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hdf5 1.12.1 to 1.12.3 #4653
base: master
Are you sure you want to change the base?
Conversation
Code extracted from: https://github.com/HDFGroup/hdf5.git at commit 106fb56936d1d785ca96147601a3608e433ddc3b (hdf5-1_12_3).
# By HDF5 Maintainers * upstream-HDF5: HDF5 2023-11-06 (106fb569) # Conflicts: # Modules/ThirdParty/HDF5/src/itkhdf5/CMakeFilters.cmake # Modules/ThirdParty/HDF5/src/itkhdf5/CMakeLists.txt # Modules/ThirdParty/HDF5/src/itkhdf5/config/cmake/ConfigureChecks.cmake # Modules/ThirdParty/HDF5/src/itkhdf5/config/cmake/HDFCompilerFlags.cmake # Modules/ThirdParty/HDF5/src/itkhdf5/config/cmake/HDFMacros.cmake # Modules/ThirdParty/HDF5/src/itkhdf5/config/cmake_ext_mod/ConfigureChecks.cmake # Modules/ThirdParty/HDF5/src/itkhdf5/config/cmake_ext_mod/HDFUseCXX.cmake # Modules/ThirdParty/HDF5/src/itkhdf5/hl/CMakeLists.txt # Modules/ThirdParty/HDF5/src/itkhdf5/src/CMakeLists.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on a glance.
It looks like pleasing the CI will take some doing. |
|
3012756 should fix that. It was OFF in ITK 5.3, I must have accidentally turned it on. |
|
@seanm please rebase on |
@seanm please also create PR's from forks -- we do not want to clutter the main repo with topic branches. |
Mmmm, not sure what you mean here? I'm pretty sure I created this PR the same way I always do... |
This smaller update seems easier to deal with than going to 1.14...