PERF: Avoid redundant searches for a data element in a gdcm::DataSet
#4650
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code requested `gdcm::DataSet` to search for one and the same data element three times in a row, by calling both FindDataElement and GetDataElement for the very same tag. With this commit, the search is only performed once. Issue found by Mihail Isakov: InsightSoftwareConsortium#4636 (comment)
github-actions
bot
added
type:Performance
dzenanz
approved these changes
May 8, 2024
issakomi
approved these changes
May 8, 2024
|
/azp run ITK.Linux |
|
I think this pull request may also be merged now, as v5.4.0 has been tagged (#4603 (comment)) |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code requested
gdcm::DataSetto search for one and the same data element three times in a row, by calling both FindDataElement and GetDataElement for the very same tag. With this commit, the search is only performed once.Issue found by Mihail Isakov (@issakomi):
#4636 (comment)
For the record, the redundant searches appear introduced with commit 168c457, June 5, 2014:
ITK/Modules/IO/GDCM/src/itkGDCMImageIO.cxx
Lines 384 to 387 in 168c457