Multilingual content support #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors
Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors
* sort results by content_id * Auth and access level * fixes from review
* MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * address leftover PR#130 comments * remove unnecessary spacing on cards * Make page buttons circular and smaller * cleanup imports * add max count to title input * Revert text box identifiers to reflect wireframe * Cleanup text boxes in Edit * add date back to cards to reflect wireframe * date to 12hr format * add space to bottom of page * reduce cardgrid density * change all instances of content_id to number (some where string) * improve delete button and modal * use the Content type in main grid * Add skeleton of search bar * Implement search functionality! * remove unnecessary wrapper * Move SearchBar and PageNavigation to components * Move sx parameters out of SearchBar component * Make CardsGrid backdrop persist even without cards on it * Convert Box to FlexBox and revert to 4-columns of cards on large screens * NavBar: add homepage link to AAQ logo * NavBar: enable links (but disable inactive pages) * NavBar: Make logo and user icon smaller * Set max cards back to 12 * Use content_id as key instead of index in Grid component * PR feedback fixes * cleanup imports * Simplify editAccess check boolean (use !editAccess) * Widen gap between date and buttons on cards --------- Co-authored-by: Sid Ravinutala <[email protected]>
* Add language table and routes as well as tests * Add english as default language in migration * Fix typos * Update core_backend/migrations/versions/1ff08438751b_add_language_table.py Co-authored-by: Amir Emami <[email protected]> * Update core_backend/app/languages/models.py Co-authored-by: Amir Emami <[email protected]> * Update core_backend/app/languages/schemas.py Co-authored-by: Amir Emami <[email protected]> * Fix comments * Fix typos --------- Co-authored-by: Amir Emami <[email protected]>
* MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * Mui admin app auth (#134) * sort results by content_id * Auth and access level * fixes from review * HOTFIX: Layout import missing from "ProtectedComponent.tsx" * MUI improvements + search bar + navbar activation (#131) * MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * address leftover PR#130 comments * remove unnecessary spacing on cards * Make page buttons circular and smaller * cleanup imports * add max count to title input * Revert text box identifiers to reflect wireframe * Cleanup text boxes in Edit * add date back to cards to reflect wireframe * date to 12hr format * add space to bottom of page * reduce cardgrid density * change all instances of content_id to number (some where string) * improve delete button and modal * use the Content type in main grid * Add skeleton of search bar * Implement search functionality! * remove unnecessary wrapper * Move SearchBar and PageNavigation to components * Move sx parameters out of SearchBar component * Make CardsGrid backdrop persist even without cards on it * Convert Box to FlexBox and revert to 4-columns of cards on large screens * NavBar: add homepage link to AAQ logo * NavBar: enable links (but disable inactive pages) * NavBar: Make logo and user icon smaller * Set max cards back to 12 * Use content_id as key instead of index in Grid component * PR feedback fixes * cleanup imports * Simplify editAccess check boolean (use !editAccess) * Widen gap between date and buttons on cards --------- Co-authored-by: Sid Ravinutala <[email protected]> * Replace old admin app with new MUI admin app (#136) * temp - remove old `src` * temp - replace/remove files * move logo png to inside admin app * Add condition for catching missing content_id * TEMP FIX: Disable missingSuspenseWithCSRBailout error. See Jira ticket 424 for details. --------- Co-authored-by: Sid Ravinutala <[email protected]>
* List content on frontend * Add frontend changes
* List content on frontend * Add frontend changes * Update retrieve language * Delete language * Fix conflicts * fix linting * format code and remove extra space above add button * Improve language filter aesthetics and resizing behaviour * Quick cleanup --------- Co-authored-by: amir_emami <[email protected]>
* List content on frontend * Add frontend changes * Update retrieve language * Delete language * Fix conflicts * fix linting * edit contents * Retrieve and delete multilingual content (#140) * List content on frontend * Add frontend changes * Update retrieve language * Delete language * Fix conflicts * fix linting * format code and remove extra space above add button * Improve language filter aesthetics and resizing behaviour * Quick cleanup --------- Co-authored-by: amir_emami <[email protected]> * Cleanup * Frontend changes * Add default language * Remove deactivated language for edit * Fix font bug * Remove emotion/server * Fix typos * Remove package.json --------- Co-authored-by: amir_emami <[email protected]>
* List content on frontend * Add frontend changes * Update retrieve language * Delete language * Fix conflicts * fix linting * edit contents * Retrieve and delete multilingual content (#140) * List content on frontend * Add frontend changes * Update retrieve language * Delete language * Fix conflicts * fix linting * format code and remove extra space above add button * Improve language filter aesthetics and resizing behaviour * Quick cleanup --------- Co-authored-by: amir_emami <[email protected]> * Cleanup * Frontend changes * Add default language * Remove deactivated language for edit * Fix font bug * Add delete contents * Code refactor to add and delete contents * Return to landing page when all languages versions are deleted * Remove emotion/server * delete package-lock.json * remove unused imports * Cleanup * Fix bugs * Add requested frontend changes * Fix text getting blank * Update content title and texts fields * add new line at end of package * Fix duplicated issue --------- Co-authored-by: amir_emami <[email protected]> Co-authored-by: Suzin You <[email protected]>
* List content on frontend * Add frontend changes * Update retrieve language * Delete language * Fix conflicts * fix linting * edit contents * Retrieve and delete multilingual content (#140) * List content on frontend * Add frontend changes * Update retrieve language * Delete language * Fix conflicts * fix linting * format code and remove extra space above add button * Improve language filter aesthetics and resizing behaviour * Quick cleanup --------- Co-authored-by: amir_emami <[email protected]> * Cleanup * Frontend changes * Add default language * Remove deactivated language for edit * Fix font bug * Add delete contents * Code refactor to add and delete contents * Return to landing page when all languages versions are deleted * Remove emotion/server * delete package-lock.json * remove unused imports * Add tests * Clean up * Fix frontend bug * fix frontend bugs * Update admin_app/package.json Co-authored-by: Suzin You <[email protected]> --------- Co-authored-by: amir_emami <[email protected]> Co-authored-by: Suzin You <[email protected]>
suzinyou
approved these changes
Apr 15, 2024
lickem22
force-pushed
the
feature-multilingual
branch
from
4e9dfa2
to
b7c13ce
Compare
amiraliemami
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @sidravi1
Estimate: 1h
Ticket
Fixes: AAQ-185
Description
Goal
The goal of this PR is to merge add the multilingual feature to main
Changes
This feature contain the following changes:
On the backend:
On the frontend:
Future Tasks (optional)
How has this been tested?
This has been tested by testing the different endpoints created/modified and testing the new functionalities on the frontend to make sure it works correctly.
Checklist
Fill with
xfor completed. Delete any lines that are not relevant