Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update eslint config to flat #1

Merged
merged 4 commits into from
May 25, 2024
Merged

Conversation

CloudNStoyan
Copy link
Contributor

No description provided.

@CloudNStoyan CloudNStoyan marked this pull request as draft May 9, 2024 20:22
@CloudNStoyan
Copy link
Contributor Author

CloudNStoyan commented May 13, 2024

Rules that are broken after the config was updated to flat

New rules that were enabled the the updated eslint recommended config

  • no-constant-binary-expression
  • no-empty-static-block
  • no-new-native-nonconstructor

New rules that were enabled by the updated typescript-eslint strictly typed config

  • @typescript-eslint/no-array-delete
  • @typescript-eslint/no-confusing-void-expression
  • @typescript-eslint/no-meaningless-void-operator
  • @typescript-eslint/no-mixed-enums
  • @typescript-eslint/no-unnecessary-boolean-literal-compare
  • @typescript-eslint/no-unnecessary-condition
  • @typescript-eslint/no-unnecessary-type-arguments
  • @typescript-eslint/no-useless-template-literals
  • @typescript-eslint/only-throw-error
  • @typescript-eslint/prefer-includes
  • @typescript-eslint/prefer-promise-reject-errors
  • @typescript-eslint/prefer-reduce-type-parameter
  • @typescript-eslint/prefer-return-this-type
  • @typescript-eslint/use-unknown-in-catch-callback-variable

New rules that were disabled by the updated typescript-eslint strictly typed config

  • no-new-native-nonconsturctor
  • no-throw-literals
  • prefer-promise-reject-errors

Updated options to already enabled rules by the new typescript-eslint strictly typed config

  • @typescript-eslint/restrict-plus-operands
    Before: It didn't specify options
    Now:
'@typescript-eslint/restrict-plus-operands': ['error', {
  allowAny: false,
  allowBoolean: false,
  allowNullish: false,
  allowNumberAndString: false,
  allowRegExp: false,
}]
  • @typescript-eslint/restrict-template-expressions
    Before: It didn't specify options
    Now:
'@typescript-eslint/restrict-template-expressions': ['error', {
  allowAny: false,
  allowBoolean: false,
  allowNullish: false,
  allowNumber: false,
  allowRegExp: false,
  allowNever: false,
}]

Rules that should be added when the config is updated to ESLint v9

@CloudNStoyan CloudNStoyan marked this pull request as ready for review May 13, 2024 08:52
@CloudNStoyan CloudNStoyan marked this pull request as draft May 13, 2024 14:24
@CloudNStoyan CloudNStoyan marked this pull request as ready for review May 16, 2024 08:10
@HristoKolev HristoKolev merged commit defa2db into HristoKolev:main May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants