Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CPUTypeMismatchException #450

Merged
merged 1 commit into from Mar 21, 2022

Conversation

apainintheneck
Copy link
Contributor

Okay, this is pretty similar to the last one. It's linked to issue #140.

  1. New exception triggers when there is a cputype or cpusubtype
    mismatch between fat header and internal macho slice in the
    FatFile#populate_machos method.

  2. Added a test for it along with adding a new binary file
    to the test/bin/llvm folder.

1. New exception triggers when there is a cputype or cputype
mismatch between fat header and internal macho slice in the
FatFile#populate_machos method.

2. Added a test for it along with adding a new binary file
to the test/bin/llvm folder.
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@woodruffw woodruffw merged commit 232c60a into Homebrew:master Mar 21, 2022
@apainintheneck apainintheneck deleted the mismatch-cputypes branch March 31, 2022 01:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants