Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formulae: skip formulae with failing bottle steps #910

Merged
merged 2 commits into from
Apr 30, 2023
Merged

formulae: skip formulae with failing bottle steps #910

merged 2 commits into from
Apr 30, 2023

Conversation

carlocab
Copy link
Member

If the bottle step fails, these should be added to
skipped_or_failed_formulae so we don't attempt to test them later.

@carlocab
formulae: skip formulae with failing bottle steps
838ab4c 
If the bottle step fails, these should be added to
`skipped_or_failed_formulae` so we don't attempt to test them later.
MikeMcQuaid
MikeMcQuaid reviewed Apr 17, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should already be marked as FAILED instead of SKIPPED. FAILED seems more appropriate here?

@carlocab
Copy link
Member Author

They're not being added to skipped_or_failed_formulae for some reason. I've switched this to failed.

MikeMcQuaid
MikeMcQuaid approved these changes Apr 29, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for now but would be good to figure out why they aren't being marked as failed without this at some later point.

@carlocab carlocab merged commit d4dff99 into Homebrew:master Apr 30, 2023
2 checks passed
@carlocab carlocab deleted the skip-failed-bottles branch April 30, 2023 04:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carlocab @MikeMcQuaid