formulae-detect: fix merge group detection #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Apr 14, 2023
This should allow `--only-formulae-detect` to work inside a merge group.
carlocab
force-pushed
the
merge-group-fix
branch
from
6e4410a
to
98a554f
Compare
MikeMcQuaid
reviewed
Apr 14, 2023
Co-authored-by: Mike McQuaid <[email protected]>
MikeMcQuaid
approved these changes
Apr 14, 2023
carlocab
added a commit
to Homebrew/homebrew-core
that referenced
this pull request
Apr 14, 2023
This will now no longer error out after Homebrew/homebrew-test-bot#905. It probably needs Homebrew/homebrew-test-bot#906 to work correctly, though.
carlocab
added a commit
to carlocab/brew
that referenced
this pull request
Apr 14, 2023
We need this in `test-bot`. See Homebrew/homebrew-test-bot#905 and Homebrew/homebrew-test-bot#906.
This was referenced Apr 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow
--only-formulae-detectto work inside a merge group.We probably also want to merge #905 so we can test this properly.