Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt 8.0.1 spdlog 1.9.1 #79836

Closed
wants to merge 11 commits into from
Closed

fmt 8.0.1 spdlog 1.9.1 #79836

wants to merge 11 commits into from

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Jun 23, 2021
@chenrui333 chenrui333 added bottle-up-everything Make every formula bottled in progress Stale bot should stay away and removed bottle-up-everything Make every formula bottled labels Jun 23, 2021
@chenrui333
Copy link
Member Author

all build issues with the revision bump, will take a look later.

@carlocab
Copy link
Member

Most of the failures should be fixed by getting spdlog to build. See gabime/spdlog#1975, gabime/spdlog#1941

watchman is tricky. It doesn't build at all at the moment, so we probably have to wait until it gets an update that will allow it to build first.

@alebcay alebcay mentioned this pull request Aug 1, 2021
Closed
@bayandin bayandin changed the title fmt 8.0.0 fmt 8.0.1 spdlog 1.9.1 Aug 3, 2021
@bayandin
Copy link
Member

bayandin commented Aug 3, 2021

Most of the failures should be fixed by getting spdlog to build. See gabime/spdlog#1975, gabime/spdlog#1941

This was fixed by updating spdlog to 1.9.1 in this PR.

watchman is tricky. It doesn't build at all at the moment, so we probably have to wait until it gets an update that will allow it to build first.

The only problem left is watchman: facebook/watchman#930

@SMillerDev
Copy link
Member

Watchman hasn't build for 2 months, I think we can try and disable it.

@carlocab
Copy link
Member

carlocab commented Aug 3, 2021 •
edited

watchman is vastly more popular (~40k installs-on-request per month) than any of the formulae it's blocking (no more than 1,000 monthly installs-on-request), though. We should try to fix it...

I suspect a good place to start would be to vendor the last version of folly that it built with in a resource block.

@cho-m
Copy link
Member

cho-m commented Aug 9, 2021

watchman is vastly more popular (~40k installs-on-request per month) than any of the formulae it's blocking (no more than 1,000 monthly installs-on-request), though. We should try to fix it...

I finally got around to working on watchman in #82474. At least the ARM CI is passing right now.

Since I am also working on Linux fixes, it may take a few more attempts if Linux CI fails.

@carlocab carlocab added CI-long-timeout Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Aug 10, 2021
@carlocab
Copy link
Member

watchman fixed in #82474. Thanks, @cho-m.

Rebased this to incorporate the fix.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2021
@chenrui333 chenrui333 deleted the bump-fmt-8.0.0 branch December 18, 2022 05:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bayandin bayandin bayandin approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-long-timeout Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. in progress Stale bot should stay away outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@chenrui333 @carlocab @bayandin @SMillerDev @cho-m @BrewTestBot