Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iconsur: prepare virtualenv to avoid issues with [email protected] #165617

Merged
merged 2 commits into from Mar 9, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Mar 9, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Supersedes and closes #163904

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 9, 2024
@chenrui333 chenrui333 mentioned this pull request Mar 9, 2024
6 tasks
@@ -333,6 +333,10 @@
"huggingface-cli": {
"exclude_packages": ["certifi"]
},
"iconsur": {
"package_name": "",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this line?

Copy link
Member Author

@cho-m cho-m Mar 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's special brew logic I added to allow brew update-python-resources iconsur to work (since iconsur is not a Python package).

Once I finish Homebrew/brew#16780, bump/bump-formula-pr will automatically update resources.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, good to know 👍

@chenrui333 chenrui333 added python Python use is a significant feature of the PR or issue and removed automerge-skip `brew pr-automerge` will skip this pull request labels Mar 9, 2024
Copy link
Contributor

github-actions bot commented Mar 9, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 9, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 9, 2024
Merged via the queue into master with commit e3d67ae Mar 9, 2024
13 checks passed
@BrewTestBot BrewTestBot deleted the iconsur-venv branch March 9, 2024 17:30
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants